speech: add missing import for code sample #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
anguillanneuf
changed the title
nnegrey
reviewed
Dec 5, 2018
| @@ -28,7 +28,10 @@ | |||
| def transcribe_file_with_enhanced_model(path): | |||
| """Transcribe the given audio file using an enhanced model.""" | |||
| # [START speech_transcribe_enhanced_model] | |||
| import io | |||
There was a problem hiding this comment.
This import exists at the top of the file.
There was a problem hiding this comment.
@beccasaurus Should we also move standard imports inside the functions for imports or just leave them outside.
There was a problem hiding this comment.
Ones like IO for reading files are 👍 – folks will find it helpful so things don't blow up
There was a problem hiding this comment.
Sounds good. @anguillanneuf
I'd say we should just make sure we remove the import above then and replace it inside the function where needed. :)
busunkim96
pushed a commit
to busunkim96/python-speech
that referenced
this pull request
Sep 1, 2020
busunkim96
pushed a commit
to googleapis/python-speech
that referenced
this pull request
Sep 3, 2020
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 13, 2023
dandhlee
pushed a commit
that referenced
this pull request
Feb 9, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
atulep
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Apr 6, 2023
atulep
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Apr 18, 2023
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.